bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/4] hurd: Don't pass fd flags in CMSG_DATA


From: Samuel Thibault
Subject: Re: [PATCH 1/4] hurd: Don't pass fd flags in CMSG_DATA
Date: Fri, 21 Apr 2023 02:56:33 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Sergey Bugaev, le ven. 21 avril 2023 00:47:43 +0300, a ecrit:
> You could think of it that way: the
> infrastructure for passing an integer value along with the port is
> still there, but currently no valid flags for it are defined, and so 0
> is always used. We could spell it as
> 
> fds[i] = descriptor->flags & ~FD_CLOEXEC;
> 
> if you would prefer;

Yes, I'd prefer.

> but that would still always evaluate to 0 (but the compiler wouldn't
> be aware and would generate the extra instructions).

Yes, sure, but that still looks preferable to me maintenance-wise.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]