bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 26/41] boot: Fix use-after-realloc


From: Sergey Bugaev
Subject: [PATCH 26/41] boot: Fix use-after-realloc
Date: Tue, 9 May 2023 00:31:21 +0300

---
 boot/boot.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/boot/boot.c b/boot/boot.c
index b661f09c..144ca1c3 100644
--- a/boot/boot.c
+++ b/boot/boot.c
@@ -486,15 +486,16 @@ read_boot_script (char **buffer, size_t *length)
       if (p == buf + len)
         {
           char *newbuf;
+          size_t newlen = len + 500;
 
-          len += 500;
-          newbuf = realloc (buf, len);
+          newbuf = realloc (buf, newlen);
           if (!newbuf)
             {
               write (2, memmsg, sizeof (memmsg));
               host_exit (1);
             }
-          p = newbuf + (p - buf);
+          p = newbuf + len;
+          len = newlen;
           buf = newbuf;
         }
     }
-- 
2.40.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]