bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [hurd,commited] hurd: Enable x86_64 build script


From: Joseph Myers
Subject: Re: [hurd,commited] hurd: Enable x86_64 build script
Date: Tue, 9 May 2023 21:53:26 +0000

I'm observing that build-many-glibcs.py runs can end up with modifications 
to the source directory (which later cause problems with updating the 
glibc checkout):

diff --git a/sysdeps/mach/hurd/bits/errno.h b/sysdeps/mach/hurd/bits/errno.h
index 069865189f..3b6363568d 100644
--- a/sysdeps/mach/hurd/bits/errno.h
+++ b/sysdeps/mach/hurd/bits/errno.h
@@ -4,11 +4,11 @@
      libc-symbols.h
      mach/message.h
      mach/kern_return.h
-     mach/i386/kern_return.h
+     mach/x86_64/kern_return.h
      mach/port.h
      mach/boolean.h
-     mach/i386/boolean.h
-     mach/i386/vm_types.h
+     mach/x86_64/boolean.h
+     mach/x86_64/vm_types.h
      stdint.h
      ../stdlib/stdint.h
      ../bits/libc-header-start.h

What this suggests to me is that the contents generated for 
sysdeps/mach/hurd/bits/errno.h depend on the system for which glibc is 
configured - which is never appropriate for a file in the source 
directory.  Either you need separate files for i386 and x86_64, or the 
contents need to avoid depending on the architecture, or the file needs to 
become purely a build-tree (and installed) file and not checked in.

-- 
Joseph S. Myers
joseph@codesourcery.com




reply via email to

[Prev in Thread] Current Thread [Next in Thread]