Re: [PATCH gnumach] Remove host_kernel_version RPC for x86_64

[Samuel Thibault]

Applied, thanks!

Flavio Cruz, le dim. 07 mai 2023 23:35:23 -0400, a ecrit:
> We can fast track the simplification of the RPC ABI for x86_64 if we don't 
> have
> MACH_MSG_TYPE_STRING used in RPCs which forces msgt_size to use more than 8
> bits.
> ---
>  include/mach/mach_host.defs |  4 ++++
>  kern/host.c                 | 10 ++++++----
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/include/mach/mach_host.defs b/include/mach/mach_host.defs
> index 90581cff..07383a57 100644
> --- a/include/mach/mach_host.defs
> +++ b/include/mach/mach_host.defs
> @@ -161,6 +161,9 @@ routine task_get_assignment(
>               task            : task_t;
>       out     assigned_set    : processor_set_name_t);
>  
> +#ifdef __x86_64__
> +skip;
> +#else
>  /*
>   *   Get string describing current kernel version.
>   *   Deprecated, use host_get_kernel_version.
> @@ -168,6 +171,7 @@ routine task_get_assignment(
>  routine      host_kernel_version(
>               host            : host_t;
>       out     kernel_version  : kernel_version_t);
> +#endif
>  
>  /*
>   *   Set priority for thread.
> diff --git a/kern/host.c b/kern/host.c
> index 50f58e9c..2db09154 100644
> --- a/kern/host.c
> +++ b/kern/host.c
> @@ -205,7 +205,7 @@ kern_return_t     host_info(
>   *   wanted to know about what version of the kernel this is).
>   */
>  
> -kern_return_t host_kernel_version(
> +kern_return_t host_get_kernel_version(
>       const host_t            host,
>       kernel_version_t        out_version)
>  {
> @@ -219,13 +219,15 @@ kern_return_t host_kernel_version(
>       return KERN_SUCCESS;
>  }
>  
> -/* Same as above */
> -kern_return_t host_get_kernel_version(
> +#ifndef __x86_64__
> +/* Same as above, but does not exist for x86_64.  */
> +kern_return_t host_kernel_version(
>       const host_t            host,
>       kernel_version_t        out_version)
>  {
> -     return host_kernel_version(host, out_version);
> +     return host_get_kernel_version(host, out_version);
>  }
> +#endif
>  
>  /*
>   *   host_processor_sets:
> -- 
> 2.39.2
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.