Re: [PATCH] exec: Allow loading x86_64 executables on x86_64

[Samuel Thibault]

Sergey Bugaev, le jeu. 11 mai 2023 17:21:06 +0300, a ecrit:
> diff --git a/exec/hostarch.c b/exec/hostarch.c
> index 363fda69..58ddc6b9 100644
> --- a/exec/hostarch.c
> +++ b/exec/hostarch.c
> @@ -70,7 +70,14 @@ elf_machine_matches_host (ElfW(Half) e_machine)
>      case CPU_TYPE_I486:
>      case CPU_TYPE_PENTIUM:
>      case CPU_TYPE_PENTIUMPRO:
> +      /* We do not support running i386 binaries if the Hurd servers were
> +         built for x86_64, or vice versa.  So our build architecture must
> +         match that of the executable.  */
> +#ifdef __x86_64__
> +      CACHE (e_machine == EM_X86_64);
> +#else
>        CACHE (e_machine == EM_386);
> +#endif

Note that I have added to gnumach CPU_TYPE_X86_64, used on 64bit gnumach
so that uname -m properly reports a 64bit architecture. So you'll rather
add the case CPU_TYPE_X86_64 there.

Samuel