[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] hurd: Fix aligning signal stack pointer
|
From: |
Adhemerval Zanella Netto |
|
Subject: |
Re: [PATCH 1/4] hurd: Fix aligning signal stack pointer |
|
Date: |
Mon, 15 May 2023 14:08:38 -0300 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 |
On 15/05/23 13:27, Samuel Thibault via Libc-alpha wrote:
> Applied, thanks!
>
> Sergey Bugaev via Libc-alpha, le lun. 15 mai 2023 11:33:20 +0300, a ecrit:
>> Fixes 60f9bf974694d50daf58d46347b06a5975ac5ddd
>> "hurd: Port trampoline.c to x86_64"
>>
>> Checked on x86_64-gnu.
>>
>> Reported-by: Bruno Haible <bruno@clisp.org>
>> Signed-off-by: Sergey Bugaev <bugaevc@gmail.com>
>> ---
>> sysdeps/mach/hurd/x86/trampoline.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/mach/hurd/x86/trampoline.c
>> b/sysdeps/mach/hurd/x86/trampoline.c
>> index e13c5d85..19bddad8 100644
>> --- a/sysdeps/mach/hurd/x86/trampoline.c
>> +++ b/sysdeps/mach/hurd/x86/trampoline.c
>> @@ -200,7 +200,7 @@ _hurd_setup_sighandler (struct hurd_sigstate *ss, const
>> struct sigaction *action
>> /* Align SP at 16 bytes. Coupled with the fact that sigreturn_addr is
>> 16-byte aligned within the stackframe struct, this ensures that it ends
>> up on a 16-byte aligned address, as required by the ABI. */
>> - sigsp = (void *) ((uintptr_t) sigsp & 16UL);
>> + sigsp = (void *) ((uintptr_t) sigsp & ~15UL);
Btw, we have the PTR_ALIGN_DOWN macro for this.