Re: [PATCH 3/3] x86_64: fix descriptor loading for 64-bit addresses

[Samuel Thibault]

Applied, thanks!

Luca Dariz, le dim. 21 mai 2023 10:57:58 +0200, a ecrit:
> * i386/i386/seg.h: use proper type for segment addresses. This is not
>   impacting any functionality on 64-bit, as segments limits are
>   ignored, but at least we silence a warning.
> ---
>  i386/i386/seg.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/i386/i386/seg.h b/i386/i386/seg.h
> index 71c05e49..673d1d9f 100644
> --- a/i386/i386/seg.h
> +++ b/i386/i386/seg.h
> @@ -32,6 +32,7 @@
>  #define      _I386_SEG_H_
>  
>  #include <mach/inline.h>
> +#include <mach/machine/vm_types.h>
>  
>  /*
>   * i386 segmentation.
> @@ -181,7 +182,7 @@ static inline void lldt(unsigned short ldt_selector)
>  
>  /* Fill a segment descriptor.  */
>  static inline void
> -fill_descriptor(struct real_descriptor *_desc, unsigned base, unsigned limit,
> +fill_descriptor(struct real_descriptor *_desc, vm_offset_t base, vm_offset_t 
> limit,
>               unsigned char access, unsigned char sizebits)
>  {
>       /* TODO: when !MACH_PV_DESCRIPTORS, setting desc and just memcpy isn't 
> simpler actually */
> -- 
> 2.30.2
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.