Re: Recent patches break ACPI tables

[Samuel Thibault]

Hello,

Damien Zammit, le dim. 18 juin 2023 00:48:15 +0000, a ecrit:
> Almu and I discovered that the following commit breaks --enable-apic 
> --enable-ncpus= >1 --disable-linux-groups
>   
> * d972c01c pmap: only map lower BIOS memory 1:1 when using Linux drivers
> 
> I believe the ACPI tables need temporary low memory mapping to access them.

Luca, what do you think?

Can we perhaps fix the ACPI code to use phystokv to translate from
physical addresses to virtual addresses?

> * 54a4ca27 x86_64: fix APIC initialization
> 
> seems wrong to me.  From memory, the ACPI spec says the offsets are always 32 
> bit for the mode of APIC we are using.

Well, yes. But it doesn't pose any problem to cast them to 64bit
integers before using them as addresses. And it's actually needed,
otherwise the compiler complains about the size difference.

Samuel