[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 1/2 hurd] libirqhelp: Add library
From: |
Damien Zammit |
Subject: |
Re: [PATCH v6 1/2 hurd] libirqhelp: Add library |
Date: |
Tue, 11 Jul 2023 01:33:39 +0000 |
Hi,
On 11/7/23 05:47, Samuel Thibault wrote:
> Damien Zammit, le lun. 10 juil. 2023 09:02:10 +0000, a ecrit:
>> +void
>> +irqhelp_wait_init(struct irq *irq)
>> +{
>> + if (!irq)
>> + {
>> + log_error("cannot wait on this irq to be ready\n");
>> + return;
>> + }
>> +
>> + sem_wait(&irq->sema);
>> +}
>
> So, is this wait really necessary? Why?
>
> AIUI at worse when the server thread will actually start, it'll just
> immediately have interrupt notifications to process.
Good question, I don't know, I will retest without it.
Damien
[PATCH v6 2/2 hurd] ddekit: Use libirqhelp for interrupt registration, Damien Zammit, 2023/07/10