bug-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3 gnumach] percpu with gs


From: Samuel Thibault
Subject: Re: [PATCH 0/3 gnumach] percpu with gs
Date: Sun, 24 Sep 2023 10:48:10 +0200
User-agent: NeoMutt/20170609 (1.8.3)

Samuel Thibault, le dim. 24 sept. 2023 10:33:39 +0200, a ecrit:
> Damien Zammit, le dim. 24 sept. 2023 05:28:34 +0000, a ecrit:
> > I did not include inlining of the cpu_number calls because
> > I noticed there was some bug introduced when I did this.
> 
> That really deserves fixing first, because it means that somehow it's
> not expressed correctly, i.e. percpu_get is not behaving properly, and
> it'll probably break when using it in other situations.

You can for instance add an inline version, and use it specifically in
the various places, to see where using it breaks, i.e. where it gets
miscompiled, and then check the assembly emitted at that place.

Samuel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]