Re: [PATCH 02/14] add basic user-space tests with qemu

[Samuel Thibault]

Hello,

Thanks, this looks good!

Luca Dariz, le jeu. 28 déc. 2023 20:42:49 +0100, a ecrit:
> new file mode 100644
> index 00000000..4cf25891
> --- /dev/null
> +++ b/tests/README
> @@ -0,0 +1,37 @@
> +
> +There are some basic tests that can be run qith qemu. You can run all the 
> tests with
> +
> +    $ make check
> +
> +or selectively with:
> +
> +    $ make run-hello
> +
> +Also, you can debug the existing tests, or a new one, by starting on one 
> shell
> +
> +    $ make debug-hello
> +
> +and on another shell you can attach with gdb, load the symbols of the
> +bootstrap module and break on its _start():
> +
> +    $ gdb gnuamch

Typo ;)

> +++ b/tests/run-qemu.sh.template
> +++ b/tests/test-hello.c
> +++ b/tests/user-qemu.mk

These are non-trivial, and so definitely need a copyright header.

> diff --git a/tests/syscalls.S b/tests/syscalls.S
> new file mode 100644
> index 00000000..df9c9bc0
> --- /dev/null
> +++ b/tests/syscalls.S
> @@ -0,0 +1,4 @@
> +

Spurious line?

> +        #include <mach/syscall_sw.h>
> +
> +        kernel_trap(invalid_syscall,-31,0)