Re: [PATCH 2/4] Avoid multiple definitions of copy_file_range

[Samuel Thibault]

Manolo de Medici, le mer. 17 janv. 2024 16:08:34 +0100, a ecrit:
> Understood, but I cannot judge if it is a bug in qemu or it fixes
> another host os,
> since qemu doesn't target only glibc.

Yes, but freebsd too uses ssize_t:

https://man.freebsd.org/cgi/man.cgi?copy_file_range(2)

glib mentions that it only exists on linux and freebsd.

https://www.gnu.org/software/gnulib/manual/html_node/copy_005ffile_005frange.html

> In order to avoid breaking other hosts, I consider it more cautious to
> ignore the difference.

Ignoring a bug is not a good thing on the long run :)

When there is something suspicious, it's useful to fix it.

> In the long term the Hurd is going to implement copy_file_range

Yes and by just fixing the prototype, we'll keep qemu able to
automatically use it when it becomes available.

Really, please, no tinkering, rather fix bugs.

Samuel