Re: [PATCH 1/2 gnumach] ioapic: Remove IMCR toggle

[Samuel Thibault]

Applied, thanks!

Damien Zammit, le mer. 24 janv. 2024 03:51:57 +0000, a ecrit:
> Since we are not using legacy MP tables but intending to use ACPI
> to configure interrupt routing, we can assume all boards have
> virtual wire mode, thus do not require setting of IMCR register.
> (This may fix crashes on machines that do not have IMCR registers).
> ---
>  i386/i386at/ioapic.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/i386/i386at/ioapic.c b/i386/i386at/ioapic.c
> index dcc91eff..fb73eab7 100644
> --- a/i386/i386at/ioapic.c
> +++ b/i386/i386at/ioapic.c
> @@ -93,12 +93,6 @@ picdisable(void)
>      */
>      outb ( PIC_SLAVE_OCW, PICS_MASK );
>      outb ( PIC_MASTER_OCW, PICM_MASK );
> -
> -    /*
> -    ** Route interrupts through IOAPIC
> -    */
> -    outb ( IMCR_SELECT, MODE_IMCR );
> -    outb ( IMCR_DATA, IMCR_USE_APIC );
>  }
>  
>  void
> -- 
> 2.43.0
> 
> 
> 

-- 
Samuel
---
Pour une évaluation indépendante, transparente et rigoureuse !
Je soutiens la Commission d'Évaluation de l'Inria.