Re: [PATCH v9 0/2 hurd] Add irqhelp and clean up ddekit

[Damien Zammit]

Hi,

On 3/10/24 6:46 AM, Samuel Thibault wrote:

> Damien Zammit, le sam. 09 mars 2024 01:18:37 +0000, a ecrit:
>> So having discussed this, we allow the irq thread to be called one more time,
>> but not actually call the user irq handler if the shutdown flag is set.
>> We acknowledge the interrupt has been handled, however.
>>
>> I tested this behaviour and it works on netdde.static to ifup and ifdown,
>> and send a large file over ssh.
> Did you try the shutdown case? Possibly by e.g. deconfiguring pfinet.

No, and I'm glad you asked me to.  It seems that there is a bug in 
mach_msg_server(),
it does not exit the while(1) loop if the irq->port is deallocated.
Is this server supposed to exit?  It would make sense if it did.
Should it check the refs on the port perhaps and break out of the loop if there 
are none left?

Damien