[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v10 0/2 hurd] Add irqhelp library and clean up ddekit
|
From: |
Samuel Thibault |
|
Subject: |
Re: [PATCH v10 0/2 hurd] Add irqhelp library and clean up ddekit |
|
Date: |
Sun, 17 Mar 2024 15:16:21 +0100 |
|
User-agent: |
NeoMutt/20170609 (1.8.3) |
Damien Zammit, le sam. 16 mars 2024 23:11:12 +0000, a ecrit:
> The previous problem was that return(NULL) was crashing netdde while
> pthread_exit(NULL) works for exiting the irq thread cleanly.
That's not clean, actually. Since the thread is created with
ddekit_thread_create, it needs to be terminated accordingly. Returning
NULL is the simplest way, ddekit_thread_exit() could be another way,
but in both case the result should be the same: _thread_cleanup will be
called to clean ddekit-related resources. Otherwise we'll be leaking
them.
What crash do you get? What is the backtrace?
(possibly there are some things to fix in our dde glue, and we do want
to fix that, not just hide the problem).
Samuel