Re: [PATCH gnumach 2/3] add tests for FLOAT/XFLOAT state

[Luca Dariz]

Il 23/08/24 11:50, Sergey Bugaev ha scritto:
> On Wed, Aug 21, 2024 at 7:37 PM Luca Dariz <luca@orpolo.org> wrote:
> > +#include <mach_i386.user.h>
> > +
> > +static void printx(struct i386_xfloat_state *state, int size)
> > +{
> > +  printf("xfloat init %d fp %d exc %d\n",
> > +         state->initialized, state->fpkind, state->exc_status);
> > +  struct i386_xfp_save *xfp = (struct i386_xfp_save *) &state->hw_state[0];
> > +  printf("xfp %d %d %d %d %d %d %d %d\n",
> > +         xfp->fp_control, xfp->fp_status, xfp->fp_tag, xfp->fp_eip,
> > +         xfp->fp_cs, xfp->fp_opcode, xfp->fp_dp, xfp->fp_ds);
>
> Please make sure to disable this on non-x86. You can disable the whole
> test, I guess, or -- would testing something like this also make sense
> on other architectures?

Make it can just fail on other archs, I guess in general we can expect 
such test to be needed.

Luca