[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: eqin comments differ from implementation
From: |
Petr Pisar |
Subject: |
Re: eqin comments differ from implementation |
Date: |
Fri, 16 Dec 2011 13:29:32 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Dec 15, 2011 at 10:00:18AM +0100, arno formella wrote:
> using indent 2.2.10 I observed that the break-function-decl-args-end
> long option was not recognized well.
>
> digging into the source I found that the comment of function "eqin"
> says that "true" is returned when the two argument strings are equal,
> however, its implementation returns "true" whenever the first argument
> is a prefix of the second one, which explains the observed behavior.
>
> suggestion: insert the line
>
> if(*s2) return false;
>
This is not proper fix. It breaks parsing other options. Run "make -C
regression" after compilation to see all the failures.
-- Petr
pgpJPIFxEZXsA.pgp
Description: PGP signature