Re: Make mes build tcc in RISC-V

[Janneke Nieuwenhuizen]

Ekaitz Zarraga writes:

Hi!

>> Please add indentation similar to other places in the file.
>> 
>> Otherwise, LGTM.
>> 
>> Janneke
>> 
>> --
>> Janneke Nieuwenhuizen janneke@gnu.org | GNU LilyPond https://LilyPond.org
>> 
>> Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com
>
>
> Great, I think this is ready.
>
> I split in two different patches, I removed some comments that were not 
> needed and
> I fixed the indentation issue.
>
> Hope this is ok.

Grand; applied to wip-riscv with minor nitpicks in the commit messages.

> From 78bc3eb1fdae0d345089294a8fd121b4e98080eb Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sun, 5 Nov 2023 13:25:57 +0100
> Subject: [PATCH 1/2] lib: Add missing (empty) crt files for RISC-V

+
                                                                    .
Added period.

> They are needed by the build scripts, but in RISC-V being empty is
> enough.
>
> * lib/linux/riscv64-mes-gcc/crti.c: New file.
> * lib/linux/riscv64-mes-gcc/crtn.c: New file.
> * lib/linux/riscv64-mes-tcc/crti.c: New file.
> * lib/linux/riscv64-mes-tcc/crtn.c: New file.

Changed to

> * lib/linux/riscv64-mes-gcc/crti.c,
lib/linux/riscv64-mes-gcc/crtn.c,
lib/linux/riscv64-mes-tcc/crti.c,
lib/linux/riscv64-mes-tcc/crtn.c: New files.

> From 8bec8882a275f09463c33503bbc5ab1cfe5f6e54 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz@elenq.tech>
> Date: Sun, 5 Nov 2023 13:28:43 +0100
> Subject: [PATCH 2/2] build: Add support for TCC in RISC-V

+                                                           .
Added period.

> For RISC-V TCC needs a modified libc because it doesn't support Extended
> Assembly. This change enables that kind of behavior, letting us select
> the TCC library when it is present.
>
> * build-aux/bootstrap.sh.in: Add a block to build-source-lib for TCC

+                                                                     .
Added period.

> * build-aux/configure-lib.sh: Guard TCC to remove repeated definitions
>   from it's libc.
  ^^       ^

Removed leading spaces and apostrophe.

Thank you!

Greetings,
Janneke

-- 
Janneke Nieuwenhuizen <janneke@gnu.org>  | GNU LilyPond https://LilyPond.org
Freelance IT https://www.JoyOfSource.com | Avatar® https://AvatarAcademy.com