Re: [bug-patch] [PATCH] do not validate target name when it is specified on the command line

[Andreas Gruenbacher]

On Wednesday 16 February 2011 09:56:00 Jim Meyering wrote:
> > Here's a patch that implements what I have in mind.  Do you really think
> > that this approach is too unsafe?
> 
> As I said: "slightly...".  No big deal.

Okay, let's go with what I have plus your review comments then.

I have uploaded a new snapshot with this fix to 
ftp://alpha.gnu.org/gnu/patch/:

        patch-2.6.1.114-f663.tar.gz

> When viewing the above using a fixed-width font, and 8-space
> TAB stops shows why using mixed TABs and spaces for indentation
> is bad.  It makes the patch much harder to read.
> 
> Have you considered indenting only with spaces?
> I've made that the policy in a few projects, and it
> has worked well.

No, I haven't considered that.  My editor introduces tabs all by itself in 
some operations.  I generally apply patches before reviewing them; that has 
worked well enough so far.

Thanks!

Andreas