[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-readline] colors.c does not compile under some mingw versions
|
From: |
Chet Ramey |
|
Subject: |
Re: [Bug-readline] colors.c does not compile under some mingw versions |
|
Date: |
Tue, 13 Aug 2019 16:07:19 -0400 |
|
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/13/19 2:57 PM, Christian Biesinger via Bug-readline wrote:
> Hello!
>
> In compiling Readline 8.0 under mingw (Windows), some versions do not
> compile because of this line in colors.c:
>
> else if (linkok == 0 && S_ISLNK(mode) &&
> _rl_color_indicator[C_ORPHAN].string != NULL)
>
> They do not support S_ISLNK. All other usages of S_ISLNK are wrapped
> in either an #ifdef HAVE_LSTAT or #ifdef S_ISLNK.
>
> So it seems that this usae should also have such an ifdef. However, an
> even easier fix would be to just remove S_ISLNK from this condition,
> because linkok can only be 0 if S_ISLNK(mode) is true, based on the
> code above.
Thanks for the report.
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, UTech, CWRU address@hidden http://tiswww.cwru.edu/~chet/