readline 8.2 FTBFS on FreeBSD/sparc

[Bruno Haible]

Hi,

On FreeBSD 12.2/sparc64, GNU readline 8.2 fails to install from source.

How to reproduce:
================================================================================
$ tar xfz readline-8.2.tar.gz 
$ cd readline-8.2
$ mkdir build-64
$ cd build-64
$ ./configure --with-curses && make

checking build system type... sparc64-unknown-freebsd12.2
checking host system type... sparc64-unknown-freebsd12.2

Beginning configuration for readline-8.2 for sparc64-unknown-freebsd12.2

checking whether make sets $(MAKE)... yes
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether gcc accepts -g... yes
checking for gcc option to enable C11 features... unsupported
checking for gcc option to enable C99 features... -std=gnu99
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for wchar.h... yes
checking for minix/config.h... no
checking whether it is safe to define __EXTENSIONS__... yes
checking whether _XOPEN_SOURCE should be defined... no
checking how to run the C preprocessor... gcc -std=gnu99 -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking whether gcc -std=gnu99 needs -traditional... no
checking for a BSD-compatible install... /usr/bin/install -c
checking for ar... ar
checking for ranlib... ranlib
checking for an ANSI C-conforming const... yes
checking for inline... inline
checking whether char is unsigned... no
checking for working volatile... yes
checking for size_t... yes
checking for ssize_t... yes
checking whether stat file-mode macros are broken... no
checking for dirent.h that defines DIR... yes
checking for library containing opendir... none required
checking for fcntl... yes
checking for gettimeofday... yes
checking for kill... yes
checking for lstat... yes
checking for pselect... yes
checking for readlink... yes
checking for select... yes
checking for setitimer... yes
checking for fnmatch... yes
checking for memmove... yes
checking for putenv... yes
checking for setenv... yes
checking for setlocale... yes
checking for strcasecmp... yes
checking for strpbrk... yes
checking for sysconf... yes
checking for tcgetattr... yes
checking for vsnprintf... yes
checking for isascii... yes
checking for isxdigit... yes
checking for getpwent... yes
checking for getpwnam... yes
checking for getpwuid... yes
checking for uid_t in sys/types.h... yes
checking for working chown... yes
checking for working strcoll... yes
checking for fcntl.h... yes
checking for unistd.h... (cached) yes
checking for stdlib.h... (cached) yes
checking for varargs.h... no
checking for stdarg.h... yes
checking for stdbool.h... yes
checking for string.h... (cached) yes
checking for strings.h... (cached) yes
checking for limits.h... yes
checking for locale.h... yes
checking for pwd.h... yes
checking for memory.h... yes
checking for termcap.h... yes
checking for termios.h... yes
checking for termio.h... no
checking for sys/ioctl.h... yes
checking for sys/pte.h... no
checking for sys/stream.h... no
checking for sys/select.h... yes
checking for sys/time.h... yes
checking for sys/file.h... yes
checking for sys/ptem.h... no
checking for special C compiler options needed for large files... no
checking for _FILE_OFFSET_BITS value needed for large files... no
checking for type of signal functions... posix
checking if signal handlers must be reinstalled when invoked... no
checking for presence of POSIX-style sigsetjmp/siglongjmp... present
checking for lstat... yes
checking whether or not strcoll and strcmp differ... no
checking whether getpw functions are declared in pwd.h... yes
checking whether termios.h defines TIOCGWINSZ... yes
checking for inttypes.h... (cached) yes
checking for sig_atomic_t in signal.h... yes
checking for TIOCSTAT in sys/ioctl.h... yes
checking for FIONREAD in sys/ioctl.h... yes
checking for speed_t in sys/types.h... no
checking for struct winsize in sys/ioctl.h and termios.h... sys/ioctl.h
checking for struct dirent.d_ino... checking for struct dirent.d_ino... yes
yes
checking for struct dirent.d_fileno... checking for struct dirent.d_fileno... 
yes
yes
checking for struct timeval in sys/time.h and time.h... yes
checking for libaudit.h... no
checking for gcc -std=gnu99 options needed to detect all undeclared 
functions... none needed
checking whether AUDIT_USER_TTY is declared... no
checking for tgetent... no
checking for tgetent in -ltermcap... yes
checking which library has the termcap functions... using libtermcap
checking for ncurses/termcap.h... no
checking for nl_langinfo and CODESET... yes
checking for wctype.h... yes
checking for wchar.h... (cached) yes
checking for langinfo.h... yes
checking for mbstr.h... no
checking for mbrlen... yes
checking for mbscasecmp... no
checking for mbscmp... no
checking for mbsnrtowcs... yes
checking for mbsrtowcs... yes
checking for mbschr... no
checking for wcrtomb... yes
checking for wcscoll... yes
checking for wcsdup... yes
checking for wcwidth... yes
checking for wctype... yes
checking for wcswidth... yes
checking whether mbrtowc and mbstate_t are properly declared... yes
checking for iswlower... yes
checking for iswupper... yes
checking for towlower... yes
checking for towupper... yes
checking for iswctype... yes
checking for wchar_t in wchar.h... yes
checking for wctype_t in wctype.h... yes
checking for wint_t in wctype.h... yes
checking for wcwidth broken with unicode combining characters... no
checking size of wchar_t... 4
checking configuration for building shared libraries... supported
configure: creating ./config.status
config.status: creating Makefile
config.status: creating doc/Makefile
config.status: creating examples/Makefile
config.status: creating shlib/Makefile
config.status: creating readline.pc
config.status: creating history.pc
config.status: creating config.h
config.status: executing stamp-h commands
rm -f readline.o
gcc -std=gnu99 -c  -DHAVE_CONFIG_H  -I. -I.. -I/home/bruno/prefix64/include 
-Wall -DRL_LIBRARY_VERSION='"8.2"' -DBRACKETED_PASTE_DEFAULT=1 -g -O2 
-Wno-parentheses -Wno-format-security 
-Wno-tautological-constant-out-of-range-compare ../readline.c
cc1: error: unrecognized command line option 
"-Wno-tautological-constant-out-of-range-compare"
*** Error code 1

Stop.
make: stopped in /home/bruno/readline-8.2/build-64
================================================================================

The problem is that the configure.ac adds the compiler option
'-Wno-tautological-constant-out-of-range-compare' unconditionally.
However, this option has only been introduced in gcc 4.4, and here

$ gcc -v
Using built-in specs.
Target: sparc64-undermydesk-freebsd
Configured with: FreeBSD/sparc64 system compiler
Thread model: posix
gcc version 4.2.1 20070831 patched [FreeBSD]

My workaround was to use

$ CFLAGS="-O2 -g" ./configure --with-curses && make

instead. But this should not be necessary. An unset CFLAGS ought to work,
and an empty CFLAGS ought to work as well.

Best regards,

                Bruno