[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] Support for Hurd translators
From: |
Marco Gerards |
Subject: |
Re: [Bug-tar] Support for Hurd translators |
Date: |
21 Jan 2004 18:31:30 +0100 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 |
Sergey Poznyakoff <address@hidden> writes:
Hi Sergey,
Thanks a lot for your looking at my patch and the fast reply.
> * Inclusions of <hurd.h> should be protected by #ifdef #endif
> * A backup definition of O_NOTRANS (#define O_NOTRANS 0) should be
> provided for non-Hurd systems.
> * The system-dependent parts (set_translator,read_trans) should go to
> system.c and should also be protected by #ifdefs.
> * There should be a code in configure.ac that would detect the presence
> of hurd.h and the hurd-specific calls (mach_port_deallocate,
> mach_task_self).
That's true, didn't I notice the autoconf stuff was missing and I have
not made sure it works on non GNU/Hurd systems in my last mail?
Please understand the patch is not yet finished, I just sent it in for
review so be sure I'm not heading in the wrong direction.
It's also important that the Hurd hackers will have a look at the
patch before you commit it, can you please wait until I did that?
I will make these changes as you noticed.
Thanks,
Marco