[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Bug-tar] Re: [PATCH] avoid compiler warning
From: |
Eric Blake |
Subject: |
[Bug-tar] Re: [PATCH] avoid compiler warning |
Date: |
Fri, 8 May 2009 15:48:01 +0000 (UTC) |
User-agent: |
Loom/3.14 (http://gmane.org/) |
Eric Blake <ebb9 <at> byu.net> writes:
>
> I noticed some use of undefined behavior of ctype macros (not all platforms
> guarantee that isxxx(char) produces sane results, when the high bit is set).
>
> * src/xheader.c (xheader_set_keyword_equal): Pass correct type to
> ctype macros.
> * src/transform.c (run_case_conv): Likewise.
Note that an alternative patch would be to rely on the gnulib c-ctype module,
where it is safe to use c_isxxx(char), and where your results are faster
because they don't depend on the current locale.
--
Eric Blake