[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] two small patches
|
From: |
Paul Eggert |
|
Subject: |
Re: [Bug-tar] two small patches |
|
Date: |
Wed, 16 Jun 2010 11:03:27 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100423 Thunderbird/3.0.4 |
Thanks for the missing prototype, but I don't see why replacing
tar_copy_str with strncpy is a win. The former is much more
efficient than the latter when the string length is much smaller
than the LEN argument. This is because the latter always stores
LEN bytes, whereas the former stores at most (string length + 1)
bytes.
Perhaps a comment should be added to tar_copy_str to explain this.