Re: [Bug-tar] [PATCH 0/1] Notes for wordsplit (was: Allow tar to usecommand for compressing consisiting of multiple words.)

[Pavel Raiskup]

On Wed, 2013-02-20 at 14:42 +0300, Sergey Poznyakoff wrote:
>> Yes, maybe not complete list of warnings/errors:
>
> Obviously, you use -Werror, which I'd rather recommend against.
> Making something like

It was just sugestion as tar uses -Werror by default since this commit:

  
http://git.savannah.gnu.org/cgit/tar.git/commit/?id=cbc51277aa4de1f41434ba073f2e4546ead63005

>>   regexec.c:586:1: error: old-style function definition 
>> [-Werror=old-style-definition]
>
> an error is way too stringent. Warnings are warnings, nothing more.

I know, but it just complicates tar's building from git repository now (and its
development then).  Everybody must use
./configure --disable-gcc-warnings.

On Wed, 2013-02-20 at 15:09 +0300, Sergey Poznyakoff wrote:
> Pavel Raiskup <address@hidden> ha escrit:
> 
> > Do not call wordsplit on multiple places when not necessary.
> > 
> > (run_decompress_program): Do not call wordsplit - rather reuse xexec.
> 
> That's wrong.  The intent of the function is to try all matching
> decompressors and find the one which works. Xexec cannot be used here
> because it exits if exec fails.

[PATCH] tar: simplify code in system.c

Oh, I forgot about it, thanks for correcting me.  What about something like
that ^^^ ?

In the this approach, there I addressed also fix for #if{,n}def MSDOS.

Pavel