[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Bug-tar] bug#15970: Crash in gettext() after fork() on Mac OS X
From: |
Paul Eggert |
Subject: |
Re: [Bug-tar] bug#15970: Crash in gettext() after fork() on Mac OS X |
Date: |
Mon, 25 Nov 2013 20:55:29 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 |
Pádraig Brady wrote:
> How about the attached instead that just uses
> a somewhat degraded but simpler error() equivalent.
That looks safe, though it could be simplified:
use inttostr instead of repeating its body,
and since !!p == !!errnum there's no need
to have those duplicate conditions.
Plus, just use STDERR_FILENO rather than
fiddling with fileno (stderr), and async_safe_error
should be _Noreturn and should unconditionally call
_exit. And, I wouldn't bother looking at dup2's
return value, any more than we look at close's.
- [Bug-tar] Crash in gettext() after fork() on Mac OS X, Guillem Jover, 2013/11/23
- Re: [Bug-tar] Crash in gettext() after fork() on Mac OS X, Eric Blake, 2013/11/23
- Re: [Bug-tar] Crash in gettext() after fork() on Mac OS X, Paul Eggert, 2013/11/24
- Re: [Bug-tar] bug#15970: Crash in gettext() after fork() on Mac OS X, Joerg Schilling, 2013/11/26
- Re: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X, Pádraig Brady, 2013/11/26
- Re: [Bug-tar] bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X, Joerg Schilling, 2013/11/27
- [Bug-tar] ignore_value vs (void) [was: bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X], Eric Blake, 2013/11/27
- Re: [Bug-tar] ignore_value vs (void) [was: bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X], Joerg Schilling, 2013/11/27
- Re: [Bug-tar] ignore_value vs (void) [was: bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X], Eric Blake, 2013/11/27
- Re: [Bug-tar] ignore_value vs (void) [was: bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X], Joerg Schilling, 2013/11/27
- Re: [Bug-tar] ignore_value vs (void) [was: bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X], Eric Blake, 2013/11/27
- Re: [Bug-tar] ignore_value vs (void) [was: bug#15970: bug#15970: Crash in gettext() after fork() on Mac OS X], Paul Eggert, 2013/11/27