Re: [Bug-tar] GCC 7 warnings

[Paul Eggert]

Pavel Raiskup wrote:
> On Friday, September 8, 2017 12:06:22 PM CEST Sergey Poznyakoff wrote:
> > Paul Eggert <address@hidden> ha escrit:
> >
> > > I suggest ignoring the warning globally by pragma (i.e., in
> > > configure.ac) since it's more trouble than it's worth for tar.
> >
> > Agreed.
>
> Please have a look at the attached patch then.

> +  nw="$nw -Wformat-overflow=2"

This part looks fine, and I suggest installing it as a separate patch.

> +  gl_WARN_ADD([-Wimplicit-fallthrough=1]) # Be more tolerant to fall-through 
> comments
>    

Instead of this, I suggest doing what Gnulib does:

# if __GNUC__ < 7
#  define FALLTHROUGH ((void) 0)
# else
#  define FALLTHROUGH __attribute__ ((__fallthrough__))
# endif

and then use 'FALLTHROUGH;' instead of comments.