Re: [Bug-tar] [PATCH] wordsplit: avoid leak if WRDSF_NOVAR is not enabled

[Pavel Raiskup]

On Tuesday, July 31, 2018 11:00:52 AM CEST Sergey Poznyakoff wrote:
> I have installed the most recent version. Thank you.

Thanks, since -Werror is the default in git, here are some new warnings:

    wordsplit.c: In function ‘wordsplit_dump_nodes’:
    wordsplit.c:560:38: error: format ‘%x’ expects argument of type ‘unsigned 
int’, but argument 5 has type ‘int’ [-Werror=format=]
      wsp->ws_debug ("(%02d) %4d: %p: %#04x (%s):%s;",
                                      ~~~~^
                                      %#04x
    wordsplit.c:562:16:
              n, p, p->flags, wsnode_flagstr (p->flags), p->v.word);
                    ~~~~~~~~               
    wordsplit.c:564:38: error: format ‘%x’ expects argument of type ‘unsigned 
int’, but argument 5 has type ‘int’ [-Werror=format=]
      wsp->ws_debug ("(%02d) %4d: %p: %#04x (%s):%.*s;",
                                      ~~~~^
                                      %#04x
    wordsplit.c:566:16:
              n, p, p->flags, wsnode_flagstr (p->flags),
                    ~~~~~~~~               
    wordsplit.c: In function ‘expvar’:
    wordsplit.c:1340:23: error: this statement may fall through 
[-Werror=implicit-fallthrough=]
           wsp->ws_usererr = value;
           ~~~~~~~~~~~~~~~~^~~~~~~
    wordsplit.c:1342:5: note: here
         default:
         ^~~~~~~

Pavel