Re: [Bug-tar] [PATCH] ZSTD compression support.

[Dmitry V. Levin]

Hi,

On Wed, Nov 15, 2017 at 10:02:12PM +0100, Adam Borowski wrote:
> Its customary file extension is ".zst", while some tools use ".tzst" as a
> shorthand for ".tar.zst".
[...]
> diff --git a/doc/tar.1 b/doc/tar.1
> index f5c1fca..b140446 100644
> --- a/doc/tar.1
> +++ b/doc/tar.1
> @@ -828,6 +828,10 @@ Filter the archive through
>  \fB\-Z\fR, \fB\-\-compress\fR, \fB\-\-uncompress\fR
>  Filter the archive through
>  .BR compress (1).
> +.TP
> +\fB\-\-zstd\fR
> +Filter the archive through
> +.BR zstd (1).
>  .SS Local file selection
>  .TP
>  \fB\-\-add\-file\fR=\fIFILE\fR

Could this be extended to include the following change, please:

diff --git a/doc/tar.1 b/doc/tar.1
index f2ccf0b..70ad107 100644
--- a/doc/tar.1
+++ b/doc/tar.1
@@ -1305,7 +1305,8 @@ failure during backup to a remote device.
 .BR lzop (1),
 .BR rmt (8),
 .BR symlink (7),
-.BR xz (1).
+.BR xz (1),
+.BR zstd (1).
 .PP
 Complete \fBtar\fR manual: run
 .B info tar

[...]
> diff --git a/doc/tar.texi b/doc/tar.texi
> index 64d1268..a5f66e0 100644
> --- a/doc/tar.texi
> +++ b/doc/tar.texi
> @@ -3713,6 +3713,10 @@ only attributes from the user namespace.
>  @itemx -J
>  Use @command{xz} for compressing or decompressing the archives.  @xref{gzip}.
>  
> address@hidden
> address@hidden --zstd
> +Use @command{zstd} for compressing or decompressing the archives.  
> @xref{gzip}.
> +
>  @end table
>  
>  @node Short Option Summary
> @@ -9569,6 +9573,7 @@ switch to @samp{posix}.
>  @cindex lzma
>  @cindex lzop
>  @cindex compress
> address@hidden zstd
>  @GNUTAR{} is able to create and read compressed archives.  It supports
>  a wide variety of compression programs, namely: @command{gzip},
>  @command{bzip2}, @command{lzip}, @command{lzma}, @command{lzop},
> @@ -9585,8 +9590,9 @@ create a @command{gzip} compressed archive, @option{-j}
>  @option{--lzip} to create an @asis{lzip} compressed archive,
>  @option{-J} (@option{--xz}) to create an @asis{XZ} archive,
>  @option{--lzma} to create an @asis{LZMA} compressed
> -archive, @option{--lzop} to create an @asis{LSOP} archive, and
> address@hidden (@option{--compress}) to use @command{compress} program.
> +archive, @option{--lzop} to create an @asis{LSOP} archive,
> address@hidden (@option{--compress}) to use @command{compress} program,
> +and @option{--zstd} to create a @asis{ZSTD} archive.
>  For example:
>  
>  @smallexample
> @@ -9779,6 +9785,8 @@ suffix.  The following suffixes are recognized:
>  @item @samp{.tlz} @tab @command{lzma}
>  @item @samp{.lzo} @tab @command{lzop}
>  @item @samp{.xz} @tab @command{xz}
> address@hidden @samp{.zst} @tab @command{zstd}
> address@hidden @samp{.tzst} @tab @command{zstd}
>  @end multitable
>  
>  @anchor{use-compress-program}

Could this be extended to include the following change, please:

diff --git a/doc/tar.texi b/doc/tar.texi
index 7581a0e..74a3b3a 100644
--- a/doc/tar.texi
+++ b/doc/tar.texi
@@ -9534,10 +9534,11 @@ switch to @samp{posix}.
 @GNUTAR{} is able to create and read compressed archives.  It supports
 a wide variety of compression programs, namely: @command{gzip},
 @command{bzip2}, @command{lz4}, @command{lzip}, @command{lzma},
address@hidden, @command{xz} and traditional @command{compress}.
-The latter is supported mostly for backward compatibility, and we recommend
-against using it, because it is by far less effective than the other
-compression address@hidden also had patent problems in the past.}.
address@hidden, @command{xz}, @command{zstd}, and traditional
address@hidden  The latter is supported mostly for backward
+compatibility, and we recommend against using it, because it is by far
+less effective than the other compression address@hidden also
+had patent problems in the past.}.
 
 Creating a compressed archive is simple: you just specify a
 @dfn{compression option} along with the usual archive creation
@@ -9681,6 +9682,10 @@ Filter the archive through @command{lzma}.
 @item --lzop
 Filter the archive through @command{lzop}.
 
address@hidden zstd
address@hidden --zstd
+Filter the archive through @command{zstd}.
+
 @opindex compress
 @opindex uncompress
 @item -Z

-- 
ldv

signature.asc
Description: PGP signature