Re: [Bug-tar] Suprising behavior of extract with --xattrs

[Nathan Stratton Treadway]

On Wed, Jun 12, 2019 at 10:32:22 -0700, Brian Murray wrote:
> diff --git a/src/xattrs.c b/src/xattrs.c
> index df65460..ed8d4e5 100644
> --- a/src/xattrs.c
> +++ b/src/xattrs.c
> @@ -636,6 +636,9 @@ xattrs_matches_mask (const char *kw, struct 
> xattrs_mask_map *mm)
>    return false;
>  }
>  
> +/* during extraction xattrs are checked against the user supplied
> +   include/exclude mask but if no mask is given then only the user.*
> +   domain is included as it may not be compatible across platforms. */

Should this last line be something like "...included, as other domains
may be incompatible across platforms and should not be applied without an
explicit user request." ?


On Wed, Jun 12, 2019 at 11:15:05 -0700, Brian Murray wrote:
> diff --git a/doc/tar.1 b/doc/tar.1
> index 18136cf..1bb9d30 100644
> --- a/doc/tar.1
> +++ b/doc/tar.1
> @@ -604,7 +604,9 @@ Enable SELinux context support.
>  Disable SELinux context support.
>  .TP
>  .B \-\-xattrs
> -Enable extended attributes support.
> +Enable extended attributes support. When creating an archive
> +\fB\-\-xattrs\-include\fR defaults to \fB'*'\fR and when extracing an
> +archive \fB\-\-xattrs\-include\fR defaults to \fB'^user.*'\fR.

s/extracing/extracting/

                                                Nathan

----------------------------------------------------------------------------
Nathan Stratton Treadway  -  address@hidden  -  Mid-Atlantic region
Ray Ontko & Co.  -  Software consulting services  -   http://www.ontko.com/
 GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt   ID: 1023D/ECFB6239
 Key fingerprint = 6AD8 485E 20B9 5C71 231C  0C32 15F3 ADCD ECFB 6239