bug-tar
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

tar-1.33 bug report


From: David Binderman
Subject: tar-1.33 bug report
Date: Fri, 8 Jan 2021 14:54:10 +0000

Hello there,

tar-1.33/lib/stdopen.c:63:22: style: Suspicious condition

Source code is

              if (mode == O_RDONLY
                  || (new_fd = open ("/dev/full", mode) != fd))

Maybe better code:

              if (mode == O_RDONLY
                  || ((new_fd = open ("/dev/full", mode)) != fd))

Regards

David Binderman




reply via email to

[Prev in Thread] Current Thread [Next in Thread]