Re: Crash on malformed archive

[Paul Eggert]

Thanks for the report. Unfortunately I'm not seeing the crash here. I'm 
running on Ubuntu 22.10 x86-64, and built tar 1.34 from source with:

  ./configure
  make CFLAGS='-g3 -O2 -fsanitize=address'

Here's my failed attempt to reproduce the bug:

  $ mkdir d
  $ cd d
  $ ../src/tar -G -g -S --acls --selinux --xattrs -x -O 
--ignore-failed-read --ignore-command-error -B --warning=none -f 
/tmp/id-000000,sig-06,src-000120+000989,time-3630314,execs-1035790,op-splice,rep-16
../src/tar: This does not look like a tar archive
../src/tar: Skipping to next header
../src/tar: Exiting with failure status due to previous errors

What platform did you build tar 1.34 on, and what configure-time options 
did you use?


> $ ./src/tar -G -g -S --acls --selinux --xattrs -x -O --ignore-failed-read
> --ignore-command-error -B --warning=none -f ./id:000001*

I noticed that your attachment was named 
"id-000000,sig-06,src-000120+000989,time-3630314,execs-1035790,op-splice,rep-16
 pid-30816", which doesn't match the globbing pattern of the failed 
command quoted above; perhaps you sent the wrong attachment?


> The reproducer is attached, and you may want to remove the checksum check
> from tar to reproduce the crash locally.

Sorry, I don't know what is meant by "remove the checksum check". I 
didn't do that, whatever it is.

Also, could you please try building from Git and testing that? It has 
fixes in this area, and the bug you reported is possibly already fixed. 
Something like this:

  git clone https://git.savannah.gnu.org/git/tar.git
  cd tar
  ./bootstrap # This takes a while....
  ./configure
  make

Thanks.