Re: warnings with -O0

[Sergey Poznyakoff]

Matteo Croce <technoboy85@gmail.com> ha escrit:

> while I generally agree that modern compilers _sometimes_ are too
> pedantic, in this case we have a macro, paxfatal(), 

It is not a macro, but a function.

> which accepts two arguments

It takes a variable number of arguments and is declared as

  _Noreturn void paxfatal (int, char const *, ...)

The error message you are referring to seems a false positive,
indeed.  FWIW, it can be avoided by replacing

  paxfatal (0, 0, _("Invalid value for record_size"));
with
  paxfatal (0, 0, "%s", _("Invalid value for record_size"));

> Either the 'dir' pointer is never NULL (and the check is useless),

It is never NULL and the check is useless.  I'll remove this later,
when my load permits me.

Regards,
Sergey