[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Some links to external manuals not followable in Info output
From: |
Patrice Dumas |
Subject: |
Re: Some links to external manuals not followable in Info output |
Date: |
Wed, 3 Apr 2024 14:28:48 +0200 |
On Wed, Apr 03, 2024 at 12:42:20PM +0100, Gavin Smith wrote:
> On Wed, Apr 03, 2024 at 12:09:04PM +0200, Patrice Dumas wrote:
> > Here is a patch for the Info reader. It passes the tests and in a test
> > with a minimum info file, followed a cross-reference as above. But I
> > may have overlooked interactions with other parts of the code.
>
> I've committed this in your name. I found it hard to understand too
> (even though I was responsible for much of this code). scan_reference_marker
> and scan_reference_target both find the targets of a reference. However,
> I don't feel like attempting to do a larger rewrite.
Actually, I did not find that code particularly hard to understand
(although I found where the issue was with fprintf, not only by
looking at the code), I do not think that a rewrite is particularly
needed. My point about interactions with other parts of the code is
more that I haven't checked that having a node name as an empty string
or 0 and a file name set in the entry structure could lead to issues
later on in the code or not.
--
Pat