[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Further reducing special case code for XS structuring
From: |
Gavin Smith |
Subject: |
Re: Further reducing special case code for XS structuring |
Date: |
Fri, 5 Apr 2024 23:44:20 +0100 |
On Fri, Apr 05, 2024 at 11:02:14PM +0200, Patrice Dumas wrote:
> > I've committed a change to remove the $no_build parameter but not the
> > $no_store parameter.
>
> It seems to me that the changes are no complete, to me the _get_parser_info
> $no_build argument should be removed too, and the build_document should
> only be called if $no_store is set. It seems to me that is would be
> better for parse_texi_line, it seems to me that if $no_store is not set,
> the tree should not be built in _get_parser_info, but in
> parse_texi_line, such that the decision to get a tree or only a handler
> is possible in future changes of parse_texi_line.
I've made this change. I agree that it is better this way.