bug-vc-dwim
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Bug-vc-dwim] bug#21120: bug#21120: vc-chlog fails if git submodules are


From: Assaf Gordon
Subject: [Bug-vc-dwim] bug#21120: bug#21120: vc-chlog fails if git submodules are dirty
Date: Wed, 29 Jul 2015 23:44:02 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

Hello,

On Mon, Jul 27, 2015 at 10:22:08PM -0700, Jim Meyering wrote:
On Wed, Jul 22, 2015 at 4:54 PM, Assaf Gordon <address@hidden> wrote:
it seems that if a project using git has a submodule that is dirty, vc-chlog
will fail to print the information about all the files.
<...>

Another possible thing is to make 'vc-dwim' abort if there are dirty
submodules, on the assumption that 'vc-dwim' is meant to prevent problematic
commits, and a dirty submodule is a hint of a potential problem.

Issuing a warning does have a little more appeal to me, but I would be happy
with a complete patch implementing either behavior (i.e., updating NEWS
and adding a test).

For starters, attached is the simpler approach of silently ignoring dirty git submodules with `vc-dwim --diff`.

Comments welcomed,
 -assaf

Attachment: vc-dwim-ignore-git-submodules.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]