Re: wget 1.21.1 fails to build on macOS (10.14, 10.15, 11.1)

[Carlo Cabrera]

Ah, yes, I see that your build uses the flag `--without-included-regex`.
That should probably take care of the build failure I'm seeing. Thanks
for the tip, Ryan.

The header of regex.c says it's part of glibc, though, so it's no
surprise that it leads to build failures on macOS. wget probably
shouldn't be using this on non-Linux platforms.

> On 25 Jan 2021, at 10:47, Ryan Schmidt <wget@ryandesign.com> wrote:
> 
> On Jan 24, 2021, at 23:40, Carlo Cabrera wrote:
> 
>> wget 1.21.1 fails to build on macOS 10.14, 10.15, and 11.1. The build
>> fails with a series of errors starting with
>> 
>>   In file included from regex.c:74:
>>   In file included from ./regexec.c:1362:
>>   ./malloc/dynarray-skeleton.c:195:13: error: expected identifier or '('
>>   __nonnull ((1))
>>               ^
>>   ./malloc/dynarray-skeleton.c:195:13: error: expected ')'
>>   ./malloc/dynarray-skeleton.c:195:12: note: to match this '('
>>   __nonnull ((1))
>>              ^
>> 
>> Complete build logs available at
>> 
>>   https://github.com/Homebrew/homebrew-core/pull/68667
>> 
>> The errors (on 11.1) starts at
>> 
>>   
>> https://github.com/Homebrew/homebrew-core/pull/68667/checks?check_run_id=1674726970#step:7:910
>> 
>> The exact same errors affect findutils 4.8.0, so the bug may not be in
>> wget. If so, I'd appreciate being pointed to the right place to submit
>> this bug report.
> 
> I don't have a solution for you yet but just as another datapoint wget 1.21.1 
> builds fine with those OS versions in MacPorts.
> 
> If you want to compare your build logs with ours, for wget 1.21.1 ours are:
> 
> https://build.macports.org/builders/ports-10.14_x86_64-builder/builds/77011/steps/install-port/logs/stdio
> 
> https://build.macports.org/builders/ports-10.15_x86_64-builder/builds/48550/steps/install-port/logs/stdio
> 
> https://build.macports.org/builders/ports-11_x86_64-builder/builds/15939/steps/install-port/logs/stdio
> 
> In the process of trying to update the MacPorts findutils port from 4.7.0 to 
> 4.8.0 just now, I encounter the same error that you see, on macOS 10.13. So 
> there is something wrong there.
>