Re: [PATCH] Add an option to notify the user when a draw is eligible

[Asher Gordon]

Asher Gordon <AsDaGo@posteo.net> writes:

> I've written a patch to add an option to notify the user when a draw
> is eligible.

I spoke with mattuc on FICS, and he said that he didn't think such a
feature should be enabled by default. So here is a patch to change the
default value of the notifyDraws option:

diff --git a/args.h b/args.h
index 7265a176..915d15fe 100644
--- a/args.h
+++ b/args.h
@@ -658,7 +658,7 @@ ArgDescriptor argDescriptors[] = {
   { "trivialDraws", ArgBoolean, (void *) &appData.trivialDraws, TRUE, 
(ArgIniType) FALSE },
   { "ruleMoves", ArgInt, (void *) &appData.ruleMoves, TRUE, (ArgIniType) 51 },
   { "repeatsToDraw", ArgInt, (void *) &appData.drawRepeats, TRUE, (ArgIniType) 
6 },
-  { "notifyDraws", ArgBoolean, (void *) &appData.notifyDraws, TRUE, 
(ArgIniType) TRUE },
+  { "notifyDraws", ArgBoolean, (void *) &appData.notifyDraws, TRUE, 
(ArgIniType) FALSE },
   { "backgroundObserve", ArgBoolean, (void *) &appData.bgObserve, TRUE, 
(ArgIniType) FALSE },
   { "dualBoard", ArgBoolean, (void *) &appData.dualBoard, TRUE, (ArgIniType) 
FALSE },
   { "autoKibitz", ArgTrue, (void *) &appData.autoKibitz, FALSE, INVALID },

I also considered adding an option to automatically claim draws, but I
wouldn't use this option, and I don't think anyone else would either,
because there are cases where you wouldn't want to claim a draw.

Oh, also, this is a bit unrelated, but here's a patch taken from Debian
to fix FTBFS with GCC 10 (my patch was created on top of this one):

From aeda5a0f7dc117657cf036dff9a2054fcbd844be Mon Sep 17 00:00:00 2001
From: Reiner Herrmann <reiner@reiner-h.de>
Date: Thu, 23 Apr 2020 01:06:40 +0200
Subject: [PATCH] Fix FTBFS with GCC 10

See https://bugs.debian.org/957972.
---
 backend.h   | 2 +-
 evalgraph.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/backend.h b/backend.h
index fae2ee63..bd280eae 100644
--- a/backend.h
+++ b/backend.h
@@ -242,7 +242,7 @@ extern GameInfo gameInfo;
 
 /* ICS vars used with backend.c and zippy.c */
 enum ICS_TYPE { ICS_GENERIC, ICS_ICC, ICS_FICS, ICS_CHESSNET /* not really 
supported */ };
-enum ICS_TYPE ics_type;
+extern enum ICS_TYPE ics_type;
 
 /* pgntags.c prototypes
  */
diff --git a/evalgraph.h b/evalgraph.h
index f4b4f920..2ab0e3c1 100644
--- a/evalgraph.h
+++ b/evalgraph.h
@@ -34,7 +34,7 @@ typedef enum { PEN_NONE, PEN_BLACK, PEN_DOTTED, 
PEN_BLUEDOTTED, PEN_BOLDWHITE, P
 #define OPEN   0
 
 /* Module globals */
-ChessProgramStats_Move * currPvInfo;
+extern ChessProgramStats_Move * currPvInfo;
 extern int currFirst;
 extern int currLast;
 extern int currCurrent;
-- 
2.28.0

Thanks,
Asher

-- 
<cas> well there ya go.  say something stupid in irc and have it
      immortalised forever in someone's .sig file
                               --------
I prefer to send and receive mail encrypted. Please send me your
public key, and if you do not have my public key, please let me
know. Thanks.

GPG fingerprint: 38F3 975C D173 4037 B397  8095 D4C9 C4FC 5460 8E68

signature.asc
Description: PGP signature