Re: crash bug in bgpd - bugfix

[Yuri Mikhaylov]

Hello,

I made bug-fix for this error, I not so sure that is very good patch,
but it has worked perfectly. I made changes in zebra-0.93a/lib/thread.c:

544,550c544,557
<       {
<         if (errno == EINTR)
<           continue;
<
<         zlog_warn ("select() error: %s", strerror (errno));
<         return NULL;
<       }
---
>       {
>               if (errno == EINTR)
>                 continue;
>               if ( errno == EINVAL )
>               {
>                 zlog_warn ("select() warning: %s, nfds=%d, sec=%ld, msec=%ld", 
strerror (errno), FD_SETSIZE, timer_wait->tv_sec, timer_wait->tv_usec );
>                 num = select (FD_SETSIZE, &readfd, &writefd, &exceptfd, NULL 
);
>               }
>               if( num < 0 )
>               {
>                 zlog_warn ("select() error: %s", strerror (errno) );
>                 return NULL;
>               }
>       }

I have got log-records like this now:
2002/08/12 13:03:01 BGP: select() warning: Invalid argument, nfds=1024, sec=3, 
msec=694216248
2002/08/13 09:31:22 BGP: select() warning: Invalid argument, nfds=1024, sec=4, 
msec=695036973

And bgp session still work smothly.

Yuri Mikhaylov wrote:
> Hello,
>
> I have used zebra v 0.93a. Router is FreeBSD 4.6 (up to stable).
> I have got very easy configuration: announce my network and
> receive fullview. But every 10-15 hours bgpd is crashed and write
> message to log:
> 2002/08/11 23:28:06 BGP: select() error: Invalid argument

--
Yuri Mikhaylov
Digital Generation, 235-9000