Re: [zebra 22449] memory leak in ospf_ls_upd

[Yasuhiro Ohara]

Below fix has been made in CVS repository.
Thanks for reporting.

regards,
yasu

Index: ospfd/ospf_packet.c
===================================================================
RCS file: /cvsroot/zebra/ospfd/ospf_packet.c,v
retrieving revision 1.297
diff -u -r1.297 ospf_packet.c
--- ospfd/ospf_packet.c 10 May 2005 20:40:46 -0000      1.297
+++ ospfd/ospf_packet.c 21 Jun 2005 00:20:27 -0000
@@ -1781,6 +1781,7 @@
   if (listcount (mylsa_upds) > 0)
     ospf_opaque_self_originated_lsa_received (nbr, mylsa_upds);
 
+  list_delete (mylsa_acks);
   list_delete (mylsa_upds);
 #endif /* HAVE_OPAQUE_LSA */
 



From: "Premnath Mangal" <address@hidden>
Subject: [zebra 22449] memory leak in ospf_ls_upd
Date: Fri, 17 Jun 2005 11:48:37 +0530

> 
> Hi,
>    Found what seems to be a memory leak
> 
> Problem: ospfd memory increases by .1 % everyday
> Network : 40 routers and 400+ LSA's
> Analysis : On running command 'sh mem' , all parameter values were same
> except link list which was increasing
> Fix: Change is in function ospf_ls_upd(ospf_packet.c) . We create 2
> lists mylsa_acks = list_new () and mylsa_upds = list_new (). Freeing
> only the latter and hence the problem
> 
> Thanks and Regards,
> Premnath M
> 
> 
> **************** CAUTION - Disclaimer *****************
> This e-mail contains PRIVILEGED AND CONFIDENTIAL INFORMATION intended solely 
> for the use of the addressee(s). If you are not the intended recipient, 
> please notify the sender by e-mail and delete the original message. Further, 
> you are not to copy, disclose, or distribute this e-mail or its contents to 
> any other person and any such actions are unlawful. This e-mail may contain 
> viruses. Infosys has taken every reasonable precaution to minimize this risk, 
> but is not liable for any damage you may sustain as a result of any virus in 
> this e-mail. You should carry out your own virus checks before opening the 
> e-mail or attachment. Infosys reserves the right to monitor and review the 
> content of all messages sent to or from this e-mail address. Messages sent to 
> or from this e-mail address may be stored on the Infosys e-mail system.
> ***INFOSYS******** End of Disclaimer ********INFOSYS***
> 
> _______________________________________________
> Zebra mailing list
> address@hidden
> http://ml.zebra.org/mailman/listinfo/zebra
>