[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] cleanup port-checking routines
From: |
Alan Post |
Subject: |
Re: [Chicken-hackers] [PATCH] cleanup port-checking routines |
Date: |
Thu, 29 Sep 2011 05:59:17 -0600 |
On Thu, Sep 29, 2011 at 03:40:42AM -0400, Felix wrote:
> The attached patch introduces a native port-check routine and
> various wrappers for checking port-direction and closed-status.
> All uses of ##sys#check-port where changed accordingly and
> redundant call to ##sys#check-port-mode where removed.
>
>
> cheers,
> felix
[snip]
> diff --git a/library.scm b/library.scm
> index 4cf975c..e53a15f 100644
> --- a/library.scm
> +++ b/library.scm
> @@ -1690,9 +1690,10 @@ EOF
> (not (##sys#slot x 1)) ) )
>
> (define (port-closed? p)
> - (##sys#check-port p 'port-closed?)
> + (##sys#check-port port 'port-closed?)
> (##sys#slot p 8))
>
You've renamed the variable in the ##sys#check-port, but not the
parameter to the routine. I don't believe this code will run as
intended.
This is the first one I noticed. I didn't check for other instances
of this same problem.
-Alan
--
.i ma'a lo bradi cu penmi gi'e du