[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Pick rest argument values directly from the argvector witho
From: |
felix . winkelmann |
Subject: |
Re: [PATCH] Pick rest argument values directly from the argvector without consing |
Date: |
Mon, 18 Nov 2019 21:20:40 +0100 |
> Thanks for the suggestions, they clean up the code quite a bit.
> Attached is a new version of the patch that implements these changes.
> I also found out that there was still a bug: when a procedure was
> customizable, the generated C rest arg accessor would crash because
> there's no "av" nor "c" in those functions.
>
> Can you double-check that the code is correct in the non-"have-av?"
> cases in c-backend.scm? I was unsure if the rest argument is always
> tN where N is the number of arguments.
Thanks for improving the patch. I could find a case where the
situation you describe applies and it looks correct to me. I rebuild
the core system with the patched compiler and run
"chicken-install -v -test awful", which ran fine as well.
felix