classpath-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[cp-patches] [RFA/JDWP] JdwpConnection


From: Keith Seitz
Subject: [cp-patches] [RFA/JDWP] JdwpConnection
Date: Mon, 06 Jun 2005 13:15:44 -0700

Hi,

This is the final class for jdwp.transport. This is where it all comes
together.

I would appreciate more eyes on the threading issues. I think I have it
right, but I could be wrong. (I don't believe I'll ever feel confident
about threading issues. Too darn sneaky!)

A note about threads in this class: this class is a thread which reads
bytes off the transport, packages them into JdwpPackets, and adds the to
a packet queue for the packet processor thread(s) to grab. So other
threads will be accessing several (but not all) methods in this class
(like getPacket, sendPacket, shutdown).

I was originally planning to overlook shutdown because the JDWP spec is
not particularly clear about shutdown. It seems that once a debugger is
attached, the only way for the debugger to disconnect is via
VirtualMachine.Exit (in "normal" situations). The spec for this command
says that the VM be "abruptly" shut down. I believe this means via
System.exit -- the whole thing (VM & back-end) dies.

FWIW, I've spent a little time on clean shutdown for the case where the
debugger just closes its connection. This could then allow the JDWP
back-end to disconnect and allow the VM to continue executing bytecode.
[Of course, we could then also allow the possibility of re-attaching the
debugger, but I am not exploring that route right now.]

Keith

ChangeLog
2005-06-06  Keith Seitz  <address@hidden>

        * gnu/classpath/jdwp/transport/JdwpConnection.java: New file.

Attachment: jdwp-connection.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]