Re: Patch: SHA1PRNG fix

[Bryce McKinlay]

Anthony Green wrote:

> I believe that these two array copies have source and destination
> operands mixed up.  This random number generator produces a never
> ending streamn of zeros otherwise.
>
> Ok to commit?

Yes, this looks fine to me.

> The Random constructor calls setSeed() at a time when SecureRandom has
> not yet initilialized secureRandomSpi, resulting in a
> NullPointerException.   This tweak fixes..
>
> EncodedKeySpec is supposed to impement KeySpec.
>
> Ok to commit?

Likewise for these.

In the absence of any active maintainers for the java.security
implementation stepping up, you should probibly feel free to check in such
fixes without approval.

regards,

Bryce.