Re: PATCH: Certificates support

[Casey Marshall]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Brian Jones wrote:
| Casey Marshall <address@hidden> writes:
|
|
|>Which brings me to a question I have about official Mauve tests: should
|>they test non-API classes that nevertheless exist in standard JDK
|>implementations (e.g. X.509 certificates, DSA, MD5 and SHA-1 -- that is
|>what exists in the "SUN" provider in Sun's JDKs)?
|
|
| Tests for functionality exposed through public APIs are okay as Sasha
| said, just don't test for Sun specific providers... we may have GNU
| providers after all.
|

I meant conformance tests for algorithms that are in Sun's default
provider and also in the GNU provider.

|>I also see that there are test/ and testsutie/ directories; should tests
|>for Classpath internals follow that paradigm?
|
|
| We no longer use the test/ or testsuite/ directories in Classpath.
|

Ok.

One additional question: parts of the patch (Base64 decoding and object
identifier DER en/decoding) use bits from other software packages --
ISC's DHCP and Cryptix's ASN.1 kit, respectively. Both are free software
and the patches use 20-30 lines from each, tops. Is this ok to include?

- --
Casey Marshall || address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD4DBQE+phPsgAuWMgRGsWsRAkZ9AJiwEPMHP/eAbbO8GNvBT1UNUnjqAJ9d+XyU
kbhfrjtr3CDGNoRdkvH+VQ==
=Ihi7
-----END PGP SIGNATURE-----