[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [patch] fix to BufferedImage
From: |
Tom Tromey |
Subject: |
Re: [patch] fix to BufferedImage |
Date: |
17 Sep 2003 10:01:37 -0600 |
User-agent: |
Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 |
>>>>> "graydon" == graydon hoare <address@hidden> writes:
graydon> 2003-09-16 Graydon Hoare <address@hidden>
graydon> * java/awt/BufferedImage.java (setData): Support non-component
graydon> sample models.
graydon> (getData): Same.
This is ok. There's a couple style nits though.
graydon> + // slower path
graydon> + int samples[] = null;
graydon> + samples = src.getPixels (x, y, w, h, samples);
The `null' here is redundant; there are a couple of these.
I'd either do the assignment and declaration at once, or just not
initialize samples. (In java this is always safe due to the definite
assignment rules.)
Tom