Guilhem> * first, it is not compilable in C++ mode. I've fixed that by
Guilhem> moving some ifdef block and adding a '}' to finish the
Guilhem> 'extern "C"' block.
Hmm, we should probably merge in the libgcj version again, there are
some minor ordering differences and whatnot here, and not for any
reason I can discern.
But this looks fine, I would say go ahead and check it in, if I come
up with a merge patch later I'll of course post it...
Guilhem> * second, I think the definition for JNI_CreateJavaVM is slightly
Guilhem> wrong. Instead of
Guilhem> JNIEXPORT jint JNICALL JNI_CreateJavaVM (JavaVM **, JNIEnv **, void *);
I agree this would be preferable, but I think the spec argues against
it.