coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] wc: fix regression determining file size


From: Pádraig Brady
Subject: Re: [PATCH] wc: fix regression determining file size
Date: Thu, 29 Dec 2022 14:19:15 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0

On 29/12/2022 13:49, Bernhard Voelker wrote:
Hi Padraig,

On 12/28/22 15:11, Pádraig Brady wrote:
* src/wc.c (wc): Use off_t rather than size_t
when calculating where to seek to, so that
we don't seek to a too low offset on systems
where size_t < off_t, which would result in
many read() calls to determine the file size.
* tests/misc/wc-proc.sh: Add a test case
sufficient for 32 bit systems at least.
Reported athttps://bugs.debian.org/1027101
---
   src/wc.c              | 2 +-
   tests/misc/wc-proc.sh | 7 +++++++
   2 files changed, 8 insertions(+), 1 deletion(-)

Nice.
As this is a user-visible change, I think this may deserve a NEWS
entry, doesn't it?

Pushed with NEWS entry:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=266b7cbc8

cheers,
Pádraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]