Re: RFC: cksum --base64/-b support

[Pádraig Brady]

On 30/01/2023 17:52, Jim Meyering wrote:
> On Sun, Jan 29, 2023 at 1:10 PM Jim Meyering <jim@meyering.net> wrote:
> > On Sun, Jan 29, 2023 at 12:40 PM Jim Meyering <jim@meyering.net> wrote:
> > ...
> > > - I'm inclined to work like the openbsd cksum and accept invocations
> > > like "cksum -a sha1x" and "cksum -a sha1b". Any objection?
> >
> > Actually, I am now **disinclined** to implement this part. It'd make
> > sense only if we were able to compute multiple checksums in a single
> > invocation.
> > Allowing that would require a fundamental redesign, which feels out of
> > scope, at least initially.
>
> Here's a proposed patch for that.

"If must be followed by white space." comment has a typo
and also not enforced explicitly, so could be removed.

valid_digits() may check beyond the end of the buffer
in the case len != BASE64_LENGTH.
Perhaps change the "else" to "else if (len == digest_hex_bytes)".
Similarly it may be more defensive / efficient to pass
digest_len out of split_3().

non padded base64 encodings are not supported.
Is that OK. Worth mentioning in texinfo if so.
A non padded negative test in cksum-c.sh would be useful.

thanks!
Pádraig