cp-tools-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Cp-tools-commit] Patch for zone ordering and separators in JavaGenerato


From: cp-tools-commit
Subject: [Cp-tools-commit] Patch for zone ordering and separators in JavaGenerator
Date: Mon, 31 Jan 2005 02:35:34 +0000
User-agent: Mutt/1.5.6+20040907i

I'm committing the attached patch which fixes two issues in JavaGenerator:

        * The ordering of zone strings is wrong, as pointed out by
        Ito on the Classpath list.  This patch ensures that the ID
        is first not last.
        * In addition, the zone string parsing now ignores zones
        which produce an ID and a series of empty strings (as
        the XML data only contains the localized examplar city name).
        If a full set of these is found, no zone data is added.
        * The separator added by Mark has been changed from |
        to \u00A6 (the same character, with a break in the center).
        This allows root.xml to again be parsed.

Changelog:

        2005-01-31  Andrew John Hughes  <address@hidden>

        * src/gnu/localegen/JavaGenerator.java:
        (JavaGenerator.JavaContent.isUsable()): New
        method to check for usability of parsed content.
        Implementations returning true are added to
        all but the implementation below.
        (JavaGenerator.TimeZoneContent.isUsable()):
        Returns the value of the usability variable,
        which may be set true during generation.
        (JavaGenerator.TimeZoneContent.generateContent(java.io.PrintWriter)):
        Content is now written to a pair of buffers, one
        for each individual set of data, and one for the whole
        block.  These are only printed if usable data is found.
        The ID is also now used first.
        (JavaGenerator.HashtableContent.generateContent(java.io.PrintWriter)):
        \u00A6 is now used as the separator character to avoid
        conflicts.

-- 
Andrew :-)

Please avoid sending me Microsoft Office (e.g. Word, PowerPoint) attachments.
See http://www.fsf.org/philosophy/no-word-attachments.html

No software patents in Europe -- http://nosoftwarepatents.com

"Value your freedom, or you will lose it, teaches history. 
`Don't bother us with politics' respond those who don't want to learn." 
-- Richard Stallman

"We've all been part of the biggest beta test the world has ever known --
Windows" 
-- Victor Wheatman, Gartner

Attachment: zones_and_sep.diff
Description: Text document

Attachment: signature.asc
Description: Digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]